Can't get "Create reviews automatically" to work

Hello!

Just trying out Upsource and can't get the Custom workflows to work as I expect.

It's connected to a VisualSVN-repository.

I have checked "Create reviews automatically" on the Custom workflows page.

Further settings:

Commit author - All.

Branch wildcard - empty.

Path wildcard - empty.

admin as reviewer.

 

With these I expect that all revisions thats commited should generate a review. But none are.

I have tried a number of other settings as well, but with no luck.

What am I doing wrong?

 

Thanks!

5 comments

Hi Joakim,

That's strange, could you please post monitoring logs?

0

Thank you.

The monitoring logs contains the error message below. It seems that if there is no commit message, the auto-create crashes.

[2016-09-27 10:52:43,650] ERROR Watches handler-1 rver.watching.ProjectWatchKind - Error while auto-creating review on revision 2799
java.lang.ArrayIndexOutOfBoundsException: 0
at com.jetbrains.upsource.backend.server.mail.MailUtils.truncateCommitMessage(MailUtils.java:194)
at com.jetbrains.upsource.backend.server.watching.ProjectWatchKind$1.lambda$performAction$478(ProjectWatchKind.java:68)
at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175)
at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175)
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
at java.util.HashMap$KeySpliterator.forEachRemaining(HashMap.java:1540)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418)
at com.jetbrains.upsource.backend.server.watching.ProjectWatchKind$1.performAction(ProjectWatchKind.java:64)
at com.jetbrains.upsource.backend.server.watching.ProjectWatchKind.performAction(ProjectWatchKind.java:207)
at com.jetbrains.upsource.backend.server.watching.WatchesHandler.handleProjectWatches(WatchesHandler.java:184)
at com.jetbrains.upsource.backend.server.watching.WatchesHandler.lambda$handleWatches$466(WatchesHandler.java:117)
at java.util.Arrays$ArrayList.forEach(Arrays.java:3880)
at com.jetbrains.upsource.backend.server.watching.WatchesHandler.handleWatches(WatchesHandler.java:108)
at com.jetbrains.upsource.backend.server.watching.WatchesHandler.lambda$new$462(WatchesHandler.java:54)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at com.jetbrains.upsource.util.NamedDaemonThreadFactory.lambda$wrapRunnable$10(NamedDaemonThreadFactory.java:34)
at java.lang.Thread.run(Thread.java:745)

0

ok, thank you for the clarification.

Does it work for commits with non empty commit message?

0

Ok, we'll try to fix that by the coming release in October.

Please watch corresponding request - https://youtrack.jetbrains.com/issue/UP-7783 

0

Please sign in to leave a comment.