We have started using upsource for doing code reviews in our organization and are in a mode of establishing a code review practice. I have a few queries related to this and would be glad to get opinions on them
Mandatory reviews - The intellij plugin/UI does not mandate creation of a review on every commit. Would it be a good practice to have the plugin prompt for assigning a reviewer (with suggestions from old reviews) every time a developer tries to commit any code changes?
End dates - I realized that since upsource follows a post commit review workflow at times developer moves ahead with other features/code fixes etc while the older reviews are just left open. Do you think having an end date when creating a review would be better or there are other practices followed that have proven to be good?
What are the best practices around reviews for large code commits/fixes? I have read that code reviews are efficient when done in small focused batches ~ 300 lines/hr or less than that. While doing reviews with upsource, we at times ended up having more than 10 sources files being changed. Should a developer break them into logical chunks or could the tool help out in some way?
Checklists - Having a look at collaborator as a code review, I came across this nice feature that could be pretty helpful during code reviews. Is this feature planned out in upsource?
Based on your experiences I would appreciate if you could share your thoughts on the above points.