Unable to create branch review

I get the message "A branch review cannot be created. Possible reasons: a) some revision in the branch is part of another review, b) head revision is pointing to several branches."

There are no open reviews in the system, so I don't think that (a) is the problem. HEAD looks like this:

[rweeks_work]rweeks@foxbat:~/dev/agile$ cat .git/HEAD
ref: refs/heads/rweeks_work
[rweeks_work]rweeks@foxbat:~/dev/agile$ cat .git/refs/heads/rweeks_work
48dc371eae0c33d2db97532bd892ae39eda80ff9

Am I missing something?

7 comments
Comment actions Permalink

Hi Russ,

Are there any closed reviews for the commits in that branch? Could you please make a screenshot of the problematic branch graph and paste it here?

Thanks in advance.

0
Comment actions Permalink

Hi, Artem,

Here's the screenshot of the branch graph. Yes, there is a closed review of one of the commits in this branch. Does this prevent a subsequent branch review?

Thanks,
-Russ



Attachment(s):
branch.png
0
Comment actions Permalink

Hi Russ,

It does. If there was a review for one of the commits in the branch, Upsource wouldn't allow to create a branch review.

As a workaround you might find this closed review, delete all reversions from it and then try to create branch review again.

Please let me know if it helps.

0
Comment actions Permalink

Yep, that did it, thanks Artem. I don't see that as a very useful approach when I have a lot of reviews in the system, though.

0
Comment actions Permalink

Well, but how should it work from your point of view? Merge existing "stand alone" reviews with newly created branch review or just ignore reviews for particular commits?

Thanks in advance.

0
Comment actions Permalink

Hi, Artem, thanks for your question.

I think at a minimum, a link to find the relevant commits would be very useful (probably a simple search string but I'm not familiar with the search syntax yet). Then I could decide what to do with the open/closed reviews that are blocking the branch review.

Getting a bit more complicated, if all the reviews that are blocking the branch review are closed, I think it's OK to proceed with the branch review. A link to see those previous closed reviews would be nice.

I guess the most complicated would be to merge all other the reviews, open or closed, into the branch review. I'm sure there are a lot of corner cases there that I'm only vaguely aware of. If you can do it smoothly, awesome, otherwise either of the previous solutions would be helpful.

0
Comment actions Permalink

Hi Russ,

Thanks for the detailed answer, will take it into account while considering enhancements in the future releases.

0

Please sign in to leave a comment.