Code analysis of java 8 code and lombok

Hi there,

we are currently testing Upsource for code reviews (who would have guessed) and I have two problems with code analysis and no idea what the reason could be.

1) The code analysis doesn't seem to detect Java 8 features like Optionals (the pom and intellij settings state that Java 8 is the minimum language level).
2) We use lombok (and the lombok intellij plugin) very often, which also doesn't seem to be recognized by Upsource. For example see the red log.warn in the screenshot, which is provided by lomboks @Slf4j annotation.

I've tried Maven and IntelliJ as a build system configuration, but with no success so far.
Is there something here that I miss?

Cheers,
Finn

PS: Java version on the machine running Upsource:
java version "1.8.0_25"
Java(TM) SE Runtime Environment (build 1.8.0_25-b17)
Java HotSpot(TM) 64-Bit Server VM (build 25.25-b02, mixed mode)



Attachment(s):
Selection_161.png
5 comments

Hi Finn,

Thanks for your interest.

1. We'll check that in our labs, corresponding request is here https://youtrack.jetbrains.com/issue/UP-2971, so you can track the progress.

2. Current Upsource version doesn't support IntelliJ plugins unfortunately. We have it in our roadmap, so should be implemented in one of the future versions.

As for build system configuration, could you please send us mvn.out file?

To find it please perform the following steps:  

 

     a. Open Upsource

     b. Click to "Browse Code" in the top

     c. In the file tree try to find mvn.out under /.idea/ directory

Thanks in advance.

0

Hi Artmen,

thank you for your time. There does not seem to be a mvn.out file in the .idea directory created by Upsource (inside the jee-folder).

I've attached a screenshot of the the file structure in Upsource. The first .idea folder is created by IntelliJ. Then there are two modules jee (the jee code base) and web for the angularjs code.
Furthermore I've attached the Build system configuration.

Cheers,
Finn



Attachment(s):
Selection_163.png
Selection_162.png
0

Hi Finn,

Thanks for the information. Configuration shown on the screenshots looks good so we would need some additiona data - files misc.xml and pom.xml.

As for Java  8 issue, please see update in our tracker - https://youtrack.jetbrains.com/issue/UP-2971

Thanks in advance

0

Hi Artme,

I've attached both files.

Thanks for the JDK8 feedback, I'll try it as soon as I can.

Cheers,
Finn



Attachment(s):
jee-pom.xml.zip
jee-.idea-misc.xml.zip
0

Hi Finn,

Thank you for sending the files, but unfortunately it's not something what we need. You sent html files from Upsource while we need content of pom.xml and misc.xml

Thanks in advance.

0

Please sign in to leave a comment.