Allowing revisions to be present in multiple code reviews

Hi,

We have a situation where we have done an interim review on a piece of code in a branch - and now we would like to perform a 'proper' review on all the revisions in the branch (including the ones that were part of the original review).

It doesn't seem like this is possible.   If I create a 'branch' review, then the review doesn't include the revisions from the original review.   I don't really want to remove the revisions from the interim review either (seems kinda messy, I think)

Any ideas on how to fix this?   If not, any chance of adding this as a feature request?

 

I'm using version 2.5.1

 

Thanks,

Steve

4 comments
Comment actions Permalink

Hi Steve,

Not sure if you got my previous comment, for some reasons it disappeared from the thread.  

How should Upsource handle comments from the review A while including the revision to the review B?

If we decide to go this way there will be a situation when the same revision has "accepted" status in review A and "rejected" status in review B. Do you think it's reasonable to have multiply statuses for the same revision?

Thanks in advance. 

 

0
Comment actions Permalink

Hi Artem,

For your first question, I don't have a strong preference.   Whilst it might be useful for people doing review B to see the comments against review A, it might get a little noisy.

 

For your second question, I would have thought the review has the status 'accepted' or 'rejected', not the specific revision.   So, I guess that means I'm ok with multiple statusus for the same revision.   In the scenario I described above, the interim review might just be a quick check the developer is on the right track.   A subsequent 'proper' review might have more reviewers or check it in more details.

Hope that helps!

 

Cheers,

Steve

0
Comment actions Permalink

Hi Steve,

Sorry for the delayed response.

From the architectural perspective the revision also might have accepted/rejected status. Besides of that we are going to introduce VCS hosting within Upsource, where it's important to have boolean value for a single revision (e.g. allow to merge pull requests only if all revisions were accepted and so on.)

So, I am afraid, that multiple reviews for a single revision is not something we might implement in the nearest future.

Anyway, thank you for the suggestion.  

As for workaround for you: why not to create branch review from the beginning and keep all collaboration there?  

0
Comment actions Permalink

Hi Artem,

Ok, we will have to use the workaround as you describe - a branch review is what we are doing now and that mostly works.

Thanks,

Steve

0

Please sign in to leave a comment.