Plugin dont show diff for review with 2 commits (original + revert)

There is review with 2 commits. In first commit - changed file. In second revert of first commit. Should plugin display diffs for this commits in such case? Now I can see only empty list in diffs panel.

3 comments
Comment actions Permalink

Hi Artem,

It's an expected behavior. Upsource shows diff correlated with all revisions in in the review. In your case diff is equal to 0. 

Btw, what is the point of reviewing such commits?

Thanks in advance.

 

0
Comment actions Permalink

What if 2nd commit (full revert) is not right fix? I will downvote such review again and request 3rd commit. But I cant see changes in 1st commit now (empty list in diffs panel). What is I want to say to author: "you should fix this part of 1st commit, but not revert it".

0
Comment actions Permalink

Hi Artem,

Accidentally missed your question. Sorry for such delayed response.

You might always check what commit should be displayed:

0

Please sign in to leave a comment.